[chore] Add pipeline module #11209
Merged
[chore] Add pipeline module #11209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
force-pushed
the
add-pipeline-module
branch
from
58c898b
to
e7a8c7d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11209 +/- ##
==========================================
- Coverage 91.87% 91.82% -0.06%
==========================================
Files 421 424 +3
Lines 19989 20067 +78
==========================================
+ Hits 18365 18426 +61
- Misses 1249 1264 +15
- Partials 375 377 +2 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Sep 18, 2024
|
We discussed the pipeline package name on the 2024-09-18 Collector stability meeting, unless anybody proposes a different name by EOW I will merge this cc @open-telemetry/collector-approvers |
djaglowski
approved these changes
Sep 19, 2024
codeboten
pushed a commit
that referenced
this pull request
Sep 23, 2024
#### Description Depends on #11209 This PR is a non-breaking implementation of #10947. It adds a new module, `pipeline`, which houses a `pipeline.ID` and `pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within the service. `pipeline.Signal` is uses to identify the signal associated to a pipeline. I do this work begrudgingly. As the PR shows, this is a huge refactor when done in a non-breaking way, will require 3 full releases, and doesn't benefit our [End Users or, in my opinion, our Component Developers or Collector Library Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences). I view this refactor as a Nice-To-Have, not a requirement for Component 1.0. <!-- Issue number if applicable --> #### Link to tracking issue Works towards #9429
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Sep 24, 2024
…emetry#11204) #### Description Depends on open-telemetry#11209 This PR is a non-breaking implementation of open-telemetry#10947. It adds a new module, `pipeline`, which houses a `pipeline.ID` and `pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within the service. `pipeline.Signal` is uses to identify the signal associated to a pipeline. I do this work begrudgingly. As the PR shows, this is a huge refactor when done in a non-breaking way, will require 3 full releases, and doesn't benefit our [End Users or, in my opinion, our Component Developers or Collector Library Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences). I view this refactor as a Nice-To-Have, not a requirement for Component 1.0. <!-- Issue number if applicable --> #### Link to tracking issue Works towards open-telemetry#9429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To facilitate the work in #11204 as some breaking changes and some deprecations, this PR adds the new pipeline module separately so that future PRs can handle the breaking changes and deprecations.
In order to make
Signaluninstantiable outside of this repo, while still being extendable in places likecomponentprofiles, a new internal module is added to handle theSignallogic. To reduce the dependency sprawl that would happen ifsignalwas an internal package ingo.opentelemetry.io/collector, I made it a module, similar toglobalgates.Link to tracking issue
Related to #10947
Testing
Added unit tests
Documentation
Added godoc comments